friendlymatthew opened a new issue, #9740: URL: https://github.com/apache/arrow-rs/issues/9740
`unshred_variant` returns `Result<VariantArray, ArrowError>` and its docs say it errors on spec violations. However, it internally calls `VariantMetadata::new`, `Variant::new_with_metadata`, and `VariantObject::iter`. All of which panics on bad input. This is clearly bad because `unshred_varaint` is meant to consume bytes that came off disk, which by definition can be wrong. Though the fix is fairly mechanical since the panicking call sites have their `try_` counterparts https://github.com/apache/arrow-rs/blob/4676c06686a5be476b5cd632493a73c803d64a04/parquet-variant-compute/src/unshred_variant.rs#L46-L61 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
