hrishikeshh-shinde opened a new pull request, #49778:
URL: https://github.com/apache/arrow/pull/49778

   ### Rationale for this change
   Arrow ships with a vendored date library that places all definitions in the 
`arrow_vendored` namespace but keeps the original header guards, leading to 
problems when used in a project that also consumes the real date library.
   
   ### What changes are included in this PR?
   Prefix all header guards with `ARROW_VENDORED_`. Update `update.sh` to apply 
the same rewrite automatically on future re-vendoring.
   
   | File | Change |
   |------|--------|
   | `date.h` | `DATE_H` → `ARROW_VENDORED_DATE_H` |
   | `tz.h` | `TZ_H` → `ARROW_VENDORED_TZ_H` |
   | `tz_private.h` | `TZ_PRIVATE_H` → `ARROW_VENDORED_TZ_PRIVATE_H` |
   | `ios.h` | `ios_hpp` → `ARROW_VENDORED_ios_hpp` |
   | `update.sh` | Added sed block for automatic guard renaming |
   
   ### Are these changes tested?
   Built Arrow C++ locally. No build breakage.
   
   ### Are there any user-facing changes?
   No API changes. Fixes a header collision for projects that also use the real 
date library.
   
   Closes #49719


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to