Copilot commented on code in PR #323:
URL: https://github.com/apache/arrow-dotnet/pull/323#discussion_r3118133614
##########
Apache.Arrow.sln:
##########
@@ -1,4 +1,4 @@
-
+
Review Comment:
The solution file now has a leading blank line (line 1). Many tools
(including Visual Studio / `dotnet sln`) expect the first line to start with
`Microsoft Visual Studio Solution File, Format Version ...` (optionally
preceded by a BOM). Remove the extra first newline (and preserve the BOM if it
was present) so the .sln parses correctly.
##########
Apache.Arrow.sln:
##########
@@ -29,11 +29,11 @@ Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") =
"Apache.Arrow.Flight.Integra
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") =
"Apache.Arrow.IntegrationTest",
"test\Apache.Arrow.IntegrationTest\Apache.Arrow.IntegrationTest.csproj",
"{E8264B7F-B680-4A55-939B-85DB628164BB}"
EndProject
-Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Apache.Arrow.Variant",
"src\Apache.Arrow.Variant\Apache.Arrow.Variant.csproj",
"{EE364C9A-CB88-4DCE-9209-6ACBB8E6934F}"
+Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Apache.Arrow.Scalars",
"src\Apache.Arrow.Scalars\Apache.Arrow.Scalars.csproj",
"{EE364C9A-CB88-4DCE-9209-6ACBB8E6934F}"
EndProject
-Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") =
"Apache.Arrow.Variant.Tests",
"test\Apache.Arrow.Variant.Tests\Apache.Arrow.Variant.Tests.csproj",
"{0C495233-010C-45F8-BAB2-D9CD0B7B9861}"
+Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") =
"Apache.Arrow.Scalars.Tests",
"test\Apache.Arrow.Scalars.Tests\Apache.Arrow.Scalars.Tests.csproj",
"{0C495233-010C-45F8-BAB2-D9CD0B7B9861}"
EndProject
-Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") =
"Apache.Arrow.Variant.Benchmarks",
"test\Apache.Arrow.Variant.Benchmarks\Apache.Arrow.Variant.Benchmarks.csproj",
"{F3A8B7C6-D5E4-4321-9ABC-DEF012345678}"
+Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") =
"Apache.Arrow.Scalars.Benchmarks",
"test\Apache.Arrow.Scalars.Benchmarks\Apache.Arrow.Scalars.Benchmarks.csproj",
"{F3A8B7C6-D5E4-4321-9ABC-DEF012345678}"
Review Comment:
This solution entry points to
`test\\Apache.Arrow.Scalars.Benchmarks\\Apache.Arrow.Scalars.Benchmarks.csproj`,
but the repository currently only contains
`test/Apache.Arrow.Variant.Benchmarks/Apache.Arrow.Variant.Benchmarks.csproj`.
Either rename/move the benchmarks project to match the new path/name, or update
the .sln entry to the actual .csproj path so the solution loads/builds.
##########
test/Apache.Arrow.Variant.Benchmarks/Apache.Arrow.Variant.Benchmarks.csproj:
##########
@@ -10,7 +10,7 @@
</ItemGroup>
<ItemGroup>
- <ProjectReference
Include="..\..\src\Apache.Arrow.Variant\Apache.Arrow.Variant.csproj" />
+ <ProjectReference
Include="..\..\src\Apache.Arrow.Scalars\Apache.Arrow.Scalars.csproj" />
<ProjectReference
Include="..\..\src\Apache.Arrow.Operations\Apache.Arrow.Operations.csproj" />
</ItemGroup>
Review Comment:
The benchmarks project file is still
`Apache.Arrow.Variant.Benchmarks.csproj` under
`test/Apache.Arrow.Variant.Benchmarks`, but `Apache.Arrow.sln` was updated to
reference
`test\\Apache.Arrow.Scalars.Benchmarks\\Apache.Arrow.Scalars.Benchmarks.csproj`.
To avoid broken builds, rename/move this benchmarks project (and its
folder/project name) to `Apache.Arrow.Scalars.Benchmarks`, or revert the .sln
entry to reference this existing .csproj.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
