thisisnic commented on code in PR #49714:
URL: https://github.com/apache/arrow/pull/49714#discussion_r3118342471
##########
r/tests/testthat/test-type.R:
##########
@@ -53,6 +53,25 @@ test_that("infer_type() infers from R type", {
)
})
+test_that("infer_type() errors clearly for POSIXct with invalid tzone", {
+ x <- as.POSIXct("2019-02-14 13:55:05", tz = "UTC")
+ attr(x, "tzone") <- 123
Review Comment:
Yeah, that's right:
```
> as.POSIXct("2019-02-14 13:55:05", tz = 123)
Error in `strptime()`:
! invalid 'tz' value
```
Does seem odd, but I guess if people are doing unusual things with custom
construction of things, it could come up? It must have as we had a user issue
opened, and it was way before everyone was doing weird stuff with AI!
:laughing:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
