alamb commented on code in PR #9730: URL: https://github.com/apache/arrow-rs/pull/9730#discussion_r3123951047
########## arrow/src/lib.rs: ########## @@ -335,14 +335,28 @@ //! * [`parquet`](https://docs.rs/parquet) - support for [Apache Parquet] //! * [`arrow-avro`](https://docs.rs/arrow-avro) - support for [Apache Avro] //! -//! # Safety and Security +//! # Security //! -//! Like many crates, this crate makes use of unsafe where prudent. However, it endeavours to be -//! sound. Specifically, **it should not be possible to trigger undefined behaviour using safe APIs.** +//! This project follows the [Apache Arrow Security Model]. //! -//! If you think you have found an instance where this is possible, please file -//! a ticket in our [issue tracker] and it will be triaged and fixed. For more information on -//! arrow's use of unsafe, see [here](https://github.com/apache/arrow-rs/tree/main/arrow#safety). +//! Unexpected behavior (e.g., panics, crashes, or infinite loops) triggered by +//! malformed input is considered a **bug**, not a security vulnerability, +//! unless it is **exploitable** by an attacker to +//! +//! * Execute arbitrary code (Remote Code Execution); +//! * Exfiltrate sensitive information from process memory (Information Disclosure); +//! +//! If you think you have found a security vulnerability, please follow the +//! reporting instructions in the repository `SECURITY.md` file. +//! +//! # Safety +//! +//! Like many crates, this crate makes use of `unsafe` where prudent. However, it endeavors to be +//! sound. Specifically, **it should not be possible to trigger undefined behavior using safe APIs.** +//! +//! For more information on the use of unsafe, see [here](https://github.com/apache/arrow-rs/tree/main/arrow#safety). Review Comment: I suggest we treat them as a security "issue" but not treated as a security **vulnerability** that requires special reporting / alerting unless there is some evidence it can actually be exploited I tried to clarify this in the "security" part of arrow/README > Unexpected behavior (e.g., panics, crashes, or infinite loops) triggered by > malformed input, and instances of undefined behavior (UB) triggered via safe > APIs are considered bugs rather than security vulnerabilities unless they are exploitable > by an attacker to I do agree this leaves some interpretation about what "exploitable by an attacker" really means but I think some level of interpretation is unavoidable for undefined behavior in principle (as it is undefined) I will add a note to the safety section referring to the security section to make this explicit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
