Tpt commented on code in PR #585:
URL:
https://github.com/apache/arrow-rs-object-store/pull/585#discussion_r3124028844
##########
Cargo.toml:
##########
@@ -54,8 +54,9 @@ hyper = { version = "1.2", default-features = false, optional
= true }
md-5 = { version = "0.10.6", default-features = false, optional = true }
quick-xml = { version = "0.38.0", features = ["serialize",
"overlapped-lists"], optional = true }
rand = { version = "0.9", default-features = false, features = ["std",
"std_rng", "thread_rng"], optional = true }
-reqwest = { version = "0.12", default-features = false, features =
["rustls-tls-native-roots", "http2"], optional = true }
+reqwest = { version = "0.13", default-features = false, features = ["http2",
"rustls-no-provider"], optional = true }
Review Comment:
Having `rustls-no-provider` as an explicit feature requires users to setup
explicitly their crypto backend. What about just not enabling anything and
letting users that want the `reqwest` auto-setup depend on `reqwest` with the
default features enabled?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
