jorgecarleitao commented on pull request #261:
URL: https://github.com/apache/arrow-rs/pull/261#issuecomment-834096310


   Thanks a lot for the investigation, @nevi-me . I agree that it is not 
trivial :)
   
   Would it be an option to export everything on the list that you presented? 
E.g. create a `parquet/logical.rs` or something that contains both 
`LogicalType` and `pub use parquet_format::LogicalType`, together with all the 
logical types in `parquet_format` (via `pub use parquet_format::X`), and an 
equivalent approach to `parquet/schema.rs` with the SchemaElement`, 
`FileMetaData`, etc?
   
   This way we only need to export what is needed, we do not require users to 
pin the version to the exact one we use, and we do not need to create 
conversion methods.
   
   If this is too much of a complexity, let's then merge this as is :) I just 
think that we are making it harder for us long run, and exposing public stuff 
is usually a one-way street, so I was trying to reduce how much we go down that 
road.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to