pitrou commented on PR #49679:
URL: https://github.com/apache/arrow/pull/49679#issuecomment-4305042134
@Alex-PLACET It looks like the benchmarks don't compile anymore?
```
/home/antoine/arrow/dev/cpp/src/arrow/compute/kernels/vector_search_sorted_benchmark.cc:
In function 'void
arrow::compute::BM_SearchSortedBinaryScalarNeedle(benchmark::State&,
SearchSortedOptions::Side)':
/home/antoine/arrow/dev/cpp/src/arrow/compute/kernels/vector_search_sorted_benchmark.cc:255:29:
error: 'BuildSortedBinaryValues' was not declared in this scope; did you mean
'BuildSortedInt64Values'?
255 | const auto values_array = BuildSortedBinaryValues(state.range(0));
| ^~~~~~~~~~~~~~~~~~~~~~~
| BuildSortedInt64Values
In file included from
/home/antoine/arrow/dev/cpp/src/arrow/compute/kernels/vector_search_sorted_benchmark.cc:18:
/home/antoine/arrow/dev/cpp/src/arrow/compute/kernels/vector_search_sorted_benchmark.cc:
In lambda function:
/home/antoine/arrow/dev/cpp/src/arrow/compute/kernels/vector_search_sorted_benchmark.cc:290:19:
error: 'BM_SearchSortedInt64ScalarNeedle' was not declared in this scope; did
you mean 'BM_SearchSortedBinaryScalarNeedle'?
290 | BENCHMARK_CAPTURE(BM_SearchSortedInt64ScalarNeedle, left,
SearchSortedOptions::Left)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/antoine/arrow/dev/cpp/src/arrow/compute/kernels/vector_search_sorted_benchmark.cc:
In lambda function:
/home/antoine/arrow/dev/cpp/src/arrow/compute/kernels/vector_search_sorted_benchmark.cc:292:19:
error: 'BM_SearchSortedInt64ScalarNeedle' was not declared in this scope; did
you mean 'BM_SearchSortedBinaryScalarNeedle'?
292 | BENCHMARK_CAPTURE(BM_SearchSortedInt64ScalarNeedle, right,
SearchSortedOptions::Right)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/antoine/arrow/dev/cpp/src/arrow/compute/kernels/vector_search_sorted_benchmark.cc:
At global scope:
/home/antoine/arrow/dev/cpp/src/arrow/compute/kernels/vector_search_sorted_benchmark.cc:253:13:
warning: 'void
arrow::compute::BM_SearchSortedBinaryScalarNeedle(benchmark::State&,
SearchSortedOptions::Side)' defined but not used [-Wunused-function]
253 | static void BM_SearchSortedBinaryScalarNeedle(benchmark::State&
state,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/antoine/arrow/dev/cpp/src/arrow/compute/kernels/vector_search_sorted_benchmark.cc:243:13:
warning: 'void
arrow::compute::BM_SearchSortedStringScalarNeedle(benchmark::State&,
SearchSortedOptions::Side)' defined but not used [-Wunused-function]
243 | static void BM_SearchSortedStringScalarNeedle(benchmark::State&
state,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
