adamreeve commented on code in PR #326:
URL: https://github.com/apache/arrow-dotnet/pull/326#discussion_r3134952990
##########
src/Apache.Arrow.Compression/Apache.Arrow.Compression.csproj:
##########
@@ -1,14 +1,9 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
- <Description>Provides decompression support for the Arrow IPC
format</Description>
- </PropertyGroup>
-
- <PropertyGroup Condition="'$(IsWindows)'=='true'">
<TargetFrameworks>netstandard2.0;net462</TargetFrameworks>
- </PropertyGroup>
- <PropertyGroup Condition="'$(IsWindows)'!='true'">
- <TargetFrameworks>netstandard2.0</TargetFrameworks>
+ <IsAotCompatible
Condition="$([MSBuild]::IsTargetFrameworkCompatible($(TargetFramework),
'net8.0'))">true</IsAotCompatible>
Review Comment:
Do you want to add net8.0 as a target framework, otherwise this will always
be false right?
##########
src/Apache.Arrow.Flight.Sql/Apache.Arrow.Flight.Sql.csproj:
##########
@@ -1,7 +1,8 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
- <TargetFramework>netstandard2.1</TargetFramework>
+ <TargetFramework>net8.0</TargetFramework>
Review Comment:
Did you intend to drop netstandard2.1 support here? Should this be
`netstandard2.1;net8.0`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
