zanmato1984 commented on PR #49860: URL: https://github.com/apache/arrow/pull/49860#issuecomment-4323891293
Thanks for the fix — catching exceptions from the initial_task to ensure the scheduler completes (instead of hanging) makes sense, and the added tests cover both the no-other-tasks case and the ‘throws after scheduling a task’ case. Minor build/IWYU nit: this change introduces direct uses of std::exception (async_util.cc) and std::runtime_error (async_util_test.cc). It may be worth adding explicit includes (<exception> / <stdexcept>) to avoid relying on transitive headers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
