alamb commented on issue #9667:
URL: https://github.com/apache/arrow-rs/issues/9667#issuecomment-4329615460

   > Entry point: ::new() vs ::builder()
   
   I recommend both, personally
   
   > Validation: Result vs panic
   
   I think keeping the same behavior is fine. We could also add a try_build or 
something that returnes a Result() so the user can pick between the options
   
   >  keep the old name?
   
   I would vote keep the old name and mark it deprecated and call to the new 
function. See deprecation guidelines in this crate
   
   > This may touch a few call sites — happy to go a different direction if 
you'd prefer keeping the separate enabled: bool flag.
   
   I am not sure without seeing the code. Maybe we can try and fix the stale 
state thing as a subsequent PR 🤔 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to