alamb commented on code in PR #9830:
URL: https://github.com/apache/arrow-rs/pull/9830#discussion_r3149858795
##########
parquet/src/encodings/rle.rs:
##########
@@ -129,6 +129,30 @@ impl RleEncoder {
bit_packed_max_size.max(rle_max_size)
}
+ /// Returns `true` if the encoder is currently in RLE accumulation mode
Review Comment:
I am always a bit confused about what part of the parquet module is
(actually) part of its public API. For anyone else that is also confused:
RleEncoder is only reachable through the encodings module, and
parquet/src/lib.rs:144 makes that module public only when the experimental
feature is enabled. In the default build it is private, and even when exposed
it is explicitly marked as having “no stability guarantees.” The docs.rs crate
page for parquet 58.0.0 also omits enc odings from the normal public API
surface, which is consistent with that setup:
https://docs.rs/parquet/58.0.0/parquet/ and the feature list notes experimental
as unstable: https://docs.rs/crate/parquet/latest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
