kou commented on code in PR #49695:
URL: https://github.com/apache/arrow/pull/49695#discussion_r3150361527
##########
compose.yaml:
##########
@@ -204,6 +205,11 @@ volumes:
ubuntu-ccache:
name: ${ARCH}-ubuntu-${UBUNTU}-ccache
+networks:
+ # GH-48068 for Flight SQL ODBC Testing
+ odbc_net:
+ external: true
+
Review Comment:
Can we use the default network instead of creating an external network
explicitly?
I think that `docker compose up` creates the default network automatically.
If we use `depends_on:`, I think that we can use `docker compose run`
without `networks:`.
##########
compose.yaml:
##########
@@ -517,6 +542,8 @@ services:
ARROW_S3: "OFF"
ARROW_SUBSTRAIT: "OFF"
# Register ODBC before running tests
+ networks:
+ - odbc_net
Review Comment:
Does this work without all `networks:`?
```suggestion
depends_on:
- dremio
```
##########
cpp/src/arrow/flight/sql/odbc/tests/dremio/set_up_dremio_instance.sh:
##########
@@ -0,0 +1,78 @@
+#!/bin/bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+set -e
+
+HOST_URL="http://localhost:9047";
+NEW_USER_URL="$HOST_URL/apiv2/bootstrap/firstuser"
+LOGIN_URL="$HOST_URL/apiv2/login"
+SQL_URL="$HOST_URL/api/v3/sql"
+
+ADMIN_USER="admin"
+ADMIN_PASSWORD="admin2025"
+
+# Wait for Dremio to be available.
+until curl -s "$NEW_USER_URL"; do
+ echo 'Waiting for Dremio to start...'
+ sleep 5
+done
Review Comment:
Do we need this?
`dremio:` in `compose.yaml` has `healthcheck:`.
##########
compose.yaml:
##########
@@ -139,6 +139,7 @@ x-hierarchy:
- fedora-python
- fedora-r-clang
- python-sdist
+ - dremio
Review Comment:
Could you keep this list in alphabetical order?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
