InCerryGit commented on PR #340: URL: https://github.com/apache/arrow-dotnet/pull/340#issuecomment-4331781834
> It feels like there are now effectively two different implementations of `ArrowMemoryReaderImplementation`: one for `MemoryStream`s and one for every other kind of stream. Given that this is an internal class, would it make more sense to have a separate `class ArrowMemoryStreamReaderImplementation : ArrowMemoryReaderImplementation` that handles the `MemoryStream`-specific flavor? That makes sense. The current change does make ArrowStreamReaderImplementation carry both the general stream path and the exposed MemoryStream path. I’ll move the MemoryStream-specific logic into a separate internal implementation while preserving the existing stream-reader ownership semantics for record batch bodies. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
