Copilot commented on code in PR #49858:
URL: https://github.com/apache/arrow/pull/49858#discussion_r3151335853
##########
python/pyarrow/_dataset.pyx:
##########
@@ -2253,6 +2253,8 @@ cdef class CsvFileFormat(FileFormat):
"""
cdef CsvFileWriteOptions opts = \
<CsvFileWriteOptions> FileFormat.make_write_options(self)
+ if 'delimiter' not in kwargs:
Review Comment:
`make_write_options` only propagates the C++ default delimiter when the
`delimiter` key is absent. If a caller passes `delimiter=None` (common when
forwarding kwargs), this will skip propagation and
`WriteOptions(delimiter=None)` will fall back to the Python default ',' instead
of the delimiter coming from `parse_options`. Consider treating `None` as
“unspecified” (e.g., check `kwargs.get('delimiter') is None`) so the propagated
delimiter is preserved unless an explicit non-None delimiter is provided.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
