amoeba commented on code in PR #4270:
URL: https://github.com/apache/arrow-adbc/pull/4270#discussion_r3151669095
##########
.github/workflows/asf-allowlist-check.yml:
##########
@@ -28,15 +28,28 @@ on:
paths:
- ".github/**"
+concurrency:
+ group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{
github.workflow }}
+ cancel-in-progress: true
+
permissions:
contents: read
jobs:
- asf-allowlist-check:
- runs-on: ubuntu-slim
+ gha:
+ name: "Analyze Actions"
+ runs-on: ubuntu-latest
steps:
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: false
+
+ # Check that actions are pinned and on the ASF allowlist.
# Intentionally unpinned to always use the latest allowlist from the ASF.
- uses: apache/infrastructure-actions/allowlist-check@main # zizmor:
ignore[unpinned-uses]
+
+ # Analyze workflows with Zizmor
+ - name: Run zizmor 🌈
+ uses: zizmorcore/zizmor-action@71321a20a9ded102f6e9ce5718a2fcec2c4f70d8
# v0.5.2
Review Comment:
```suggestion
uses:
zizmorcore/zizmor-action@b1d7e1fb5de872772f31590499237e7cce841e8e # v0.5.3
```
Any reason not to use the latest version here?
##########
.github/workflows/packaging.yml:
##########
@@ -223,8 +228,10 @@ jobs:
- name: Show inputs
run: |
echo "upload_artifacts: ${{ inputs.upload_artifacts }}" >>
$GITHUB_STEP_SUMMARY
- echo "schedule: ${{ github.event.schedule }}" >> $GITHUB_STEP_SUMMARY
- echo "ref: ${{ github.ref }}" >> $GITHUB_STEP_SUMMARY
+ echo "schedule: ${GITHUB_EVENT_SCHEDULE}" >> $GITHUB_STEP_SUMMARY
+ echo "ref: ${GITHUB_REF}" >> $GITHUB_STEP_SUMMARY
+ env:
+ GITHUB_EVENT_SCHEDULE: ${{ github.event.schedule }}
Review Comment:
same nit
##########
.github/workflows/packaging.yml:
##########
@@ -168,10 +171,12 @@ jobs:
- name: Show inputs
run: |
echo "upload_artifacts: ${{ inputs.upload_artifacts }}" >>
$GITHUB_STEP_SUMMARY
- echo "schedule: ${{ github.event.schedule }}" >> $GITHUB_STEP_SUMMARY
- echo "ref: ${{ github.ref }}" >> $GITHUB_STEP_SUMMARY
+ echo "schedule: ${GITHUB_EVENT_SCHEDULE}" >> $GITHUB_STEP_SUMMARY
+ echo "ref: ${GITHUB_REF}" >> $GITHUB_STEP_SUMMARY
+ env:
+ GITHUB_EVENT_SCHEDULE: ${{ github.event.schedule }}
Review Comment:
nit, maybe move `env` above `run` just for the benefit of reading order?
##########
.github/workflows/packaging.yml:
##########
@@ -332,8 +339,10 @@ jobs:
- name: Show inputs
run: |
echo "upload_artifacts: ${{ inputs.upload_artifacts }}" >>
$GITHUB_STEP_SUMMARY
- echo "schedule: ${{ github.event.schedule }}" >> $GITHUB_STEP_SUMMARY
- echo "ref: ${{ github.ref }}" >> $GITHUB_STEP_SUMMARY
+ echo "schedule: ${GITHUB_EVENT_SCHEDULE}" >> $GITHUB_STEP_SUMMARY
+ echo "ref: ${GITHUB_REF}" >> $GITHUB_STEP_SUMMARY
+ env:
+ GITHUB_EVENT_SCHEDULE: ${{ github.event.schedule }}
Review Comment:
same nit. and more below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
