bparks13 commented on PR #343: URL: https://github.com/apache/arrow-dotnet/pull/343#issuecomment-4348134621
@CurtHagenlocher @adamreeve Thanks for the comments, I appreciate the perspective here. Unfortunately, in this case I’m not able to add a dependency on a newer version of `ZstdSharp`. The Bonsai plugin model uses a custom dependency resolver that requires strongly-typed assembly versions to match exactly. Because of that, a mismatch between `System.Memory` v4.5.5 and v4.6.0 results in a runtime exception when compression is used, which is not something that can be resolved by the plugin model (e.g., via binding redirects or version overrides). I definitely understand the concern about not catering to a specific downstream consumer. My thinking with this change is that it primarily brings `ZstdSharp` in line with the `System.Memory` version used in this repo. The changes between v0.8.5 and v0.8.8 do appear to be minimal. Given `System.Memory` and related packages have been stable for a while, this felt like a relatively low-risk way to avoid runtime issues that would otherwise be difficult to overcome. Happy to discuss this further, I want to make sure this is the right decision. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
