lriggs commented on PR #49887: URL: https://github.com/apache/arrow/pull/49887#issuecomment-4348557905
I think this is ok, but I would consider adding a comment in the test code about the fragility around DST times. An alternative my AI assistant proposed is using timegm instead of mktime and then you can also remove the Hack in Epoch(). The only trick is that windows needs a timegm definition, like this: #ifdef _WIN32 / #define timegm _mkgmtime Apparently some implementations of mktime account for DST and others dont. That approach might be worth trying out locally to see if it fixes the failing test. https://github.com/apache/arrow/pull/49902 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
