alamb commented on code in PR #9864:
URL: https://github.com/apache/arrow-rs/pull/9864#discussion_r3173144538
##########
parquet/src/basic.rs:
##########
@@ -798,6 +798,28 @@ fn i32_to_encoding(val: i32) -> Encoding {
// ----------------------------------------------------------------------
// Mirrors thrift enum `CompressionCodec`
+thrift_enum!(
Review Comment:
I like that this matches the name `CompressionCodec` used in the thrift
definition:
https://github.com/apache/parquet-format/blob/96edf77704b60b6f3ca2232c218c64eff6c874d3/src/main/thrift/parquet.thrift#L642
I think it makes the code easier to understand
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
