alamb commented on code in PR #9678:
URL: https://github.com/apache/arrow-rs/pull/9678#discussion_r3174308112
##########
parquet/benches/metadata.rs:
##########
@@ -143,7 +143,8 @@ fn encoded_meta(is_nullable: bool, has_lists: bool) ->
Vec<u8> {
let mut buffer = Vec::with_capacity(1024);
{
let buf = TrackedWrite::new(&mut buffer);
- let writer = ParquetMetaDataWriter::new_with_tracked(buf, &metadata);
+ let writer = ParquetMetaDataWriter::new_with_tracked(buf, &metadata)
Review Comment:
Should we perhaps make a new benchmark so we can evaluate the performance
both in default mode and wihtout this part of the metadata?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
