albertlockett commented on code in PR #9871:
URL: https://github.com/apache/arrow-rs/pull/9871#discussion_r3192168899
##########
arrow-string/src/like.rs:
##########
@@ -187,6 +189,30 @@ pub fn contains(left: &dyn Datum, right: &dyn Datum) ->
Result<BooleanArray, Arr
like_op(Op::Contains, left, right)
}
+/// Perform equality check on two byte arrays using an ASCII case-insensitive
match.
Review Comment:
good catch. fixed in 1f3b03cbb
"byte array" probably isn't the right wording here. I removed the word
"byte" to avoid confusion, and the rust doc also lists the types.
Unrelated question - wondering if e should support large string view in
these functions as well?
##########
arrow-string/src/like.rs:
##########
@@ -1394,6 +1425,22 @@ mod tests {
vec![true, false, true, true, true]
);
+ test_utf8!(
+ test_utf8_array_eq_ignore_ascii_case,
+ vec!["arrow", "arrow", "arrow", "parquet", "parquet"],
Review Comment:
yes, added in 1f3b03cbb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
