Reranko05 opened a new pull request, #49951:
URL: https://github.com/apache/arrow/pull/49951
### Rationale for this change
The decimal-specific `VisitInExpression` LLVM generation path embedded a raw
holder pointer directly into generated object code. When Gandiva reused cached
object code, the embedded pointer could become stale, leading to crashes during
cached decimal `in_expr` evaluation.
### What changes are included in this PR?
- Updated decimal `in_expr` LLVM generation to load holder pointers
dynamically at runtime using `arg_holder_ptrs_`, matching the existing generic
`InExpression` implementation.
- Added a regression test covering cached decimal `in_expr` execution.
### Are these changes tested?
Yes.
- Reproduced the crash locally before the fix.
- Verified the new regression test passes after the fix.
- Ran:
- `TestIn.TestInDecimalCached`
- `TestIn.*`
- repeated cached execution using `--gtest_repeat=100`
### Are there any user-facing changes?
No.
**This PR contains a "Critical Fix".**
This change fixes a cache-path crash in Gandiva when evaluating decimal
`in_expr` expressions using cached object code.
GitHub Issue: #39784
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
