dbatomic opened a new pull request, #721:
URL: https://github.com/apache/arrow-rs-object-store/pull/721
# Which issue does this PR close?
Closes #720.
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
Users implementing their own `CredentialProvider<Credential =
AzureCredential>` that fetches SAS tokens at request time (e.g. tokens
refreshed from a secret manager or coordination service) currently have to
reimplement this parser to feed pairs into
`AzureCredential::SASToken`. Reimplementations are easy to get subtly wrong:
in particular, using `form_urlencoded` decodes `+` as space, which corrupts
base64-encoded SAS signatures.
Make `split_sas` public, change its return type to the public
`crate::Result<Vec<(String, String)>>` (the inner `Error` variants already
convert into `crate::Error` via the existing `From` impl, so the two existing
internal call sites are unchanged), document it, and re-export it from
`object_store::azure`. Add tests for the empty/`?` edge cases and the
missing-`=` error path.
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
Plumbing to make `split_sas` public and additional test coverage. I tried to
keep changes minimal - let me know if a broader API change is needed here,
instead of a free function export.
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
No.
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please call them out.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
