pitrou commented on PR #49599:
URL: https://github.com/apache/arrow/pull/49599#issuecomment-4442319173

   Sorry @abhishek593 that nobody reviewed this before.
   
   For the safe of easier reviewing, can you divide this work into at least two 
separate PRs?
   1. a PR that uses existing concepts from the C++ standard library (such as 
`std::integral_v`, etc.)
   2. a PR that adds and uses Arrow-specific concepts (such as 
`arrow_binary_like`, etc.)
   
   I would recommend starting with 1 as it will probably be easier to get in. 
It will also help find out if we are blocked by any of the compilers on our 
existing CI platforms (which unfortunately might happen).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to