lidavidm commented on code in PR #816:
URL: https://github.com/apache/arrow-go/pull/816#discussion_r3245313165
##########
arrow/array/booleanbuilder.go:
##########
@@ -243,6 +243,7 @@ func (b *BooleanBuilder) Unmarshal(dec *json.Decoder) error
{
func (b *BooleanBuilder) UnmarshalJSON(data []byte) error {
dec := json.NewDecoder(bytes.NewReader(data))
dec.UseNumber()
+ dec.UseNumber()
Review Comment:
Er, there's a duplicate call...
##########
arrow/array/json_reader.go:
##########
@@ -78,8 +96,9 @@ type JSONReader struct {
cur arrow.RecordBatch
err error
- chunk int
- done bool
+ chunk int
+ useNumber bool
Review Comment:
This seems to be unused?
##########
arrow/array/json_reader.go:
##########
@@ -62,6 +62,24 @@ func WithAllocator(mem memory.Allocator) Option {
}
}
+// WithUseNumberJSONReader previously enabled UseNumber on the JSONReader's
+// internal json.Decoder. As of issue #804, NewJSONReader unconditionally
+// enables UseNumber so integer values too large to fit in float64 are
+// preserved. This option is now a no-op and is retained for backward
+// compatibility.
+//
+// Deprecated: UseNumber is now always enabled; this option has no effect.
+func WithUseNumberJSONReader() Option {
Review Comment:
Er, why are we adding a new, immediately deprecated, option? There's no such
option currently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
