CurtHagenlocher opened a new pull request, #4341:
URL: https://github.com/apache/arrow-adbc/pull/4341
Closes #4329
The driver manager was parsing every TOML file as a connection profile, so
real driver manifests (with `manifest_version = 1` and a string `version`) were
rejected with "The 'profile_version' field has an invalid value '1.5.2'. It
must be an integer." Add a proper DriverManifest parser per
docs/source/format/driver_manifests.rst, with [Driver.shared] as either a
single string or a platform-tuple table.
Managed (.NET) driver selection moves from the C#-specific `driver_type`
field on connection profiles to a scheme-prefixed entrypoint on the manifest:
`dotnet:Type` for modern .NET, `netfx:Type` for .NET Framework. The host
rejects a manifest whose scheme doesn't match its runtime, so mismatches fail
with a clear error instead of an assembly-loader mystery. Profile-driven
managed loading uses the same scheme via an `entrypoint` option in `[Options]`,
which the driver manager consumes and does not forward to the driver.
Also aligns env_var placeholder support with the spec syntax `{{
env_var(NAME) }}` per docs/source/format/connection_profiles.rst: placeholders
may be embedded anywhere in a value, repeated, missing vars expand to ""
(matching the C/C++ driver manager), and unknown functions are rejected.
End-to-end coverage against DuckDB lives in
DriverManifestTests.FindLoadDriver_WithRealDriverManifest_LoadsDuckDbDriver.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
