swanandx commented on code in PR #9961:
URL: https://github.com/apache/arrow-rs/pull/9961#discussion_r3279581948
##########
arrow-cast/src/parse.rs:
##########
@@ -1797,6 +1831,32 @@ mod tests {
}
}
+ #[test]
+ fn parse_date32_extended_year() {
+ // `Date32` covers any i32 days-from-epoch, verify we can parse it
+ let cases: &[(&str, i32)] = &[
+ ("+1970-01-01", 0),
+ ("+2024-01-01", 19_723),
+ ("-0001-01-01", -719_893),
+ ("+29349-01-26", 10_000_000),
+ ("+2739877-01-03", 1_000_000_000),
+ // Extremes of the Date32 representable range.
+ ("+5881580-07-11", i32::MAX),
+ ("-5877641-06-23", i32::MIN),
+ ];
Review Comment:
thanks for verifying!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
