liamzwbao commented on code in PR #9986:
URL: https://github.com/apache/arrow-rs/pull/9986#discussion_r3295115446
##########
arrow-select/src/filter.rs:
##########
@@ -843,17 +837,11 @@ fn filter_byte_view<T: ByteViewType>(
predicate: &FilterPredicate,
) -> GenericByteViewArray<T> {
let new_view_buffer = filter_native(array.views(), predicate);
+ let views = ScalarBuffer::new(new_view_buffer, 0, predicate.count);
Review Comment:
I looked into `ScalarBuffer::new_unchecked`, the docstring says "Only use
for testing purpose," and the only caller is an FFI test that needs to bypass
the alignment assertion to repro a dangling-pointer case. Consider the check is
relatively cheap, maybe we could leave it as-is unless we see it show up in a
benchmark
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
