alamb commented on issue #7870: URL: https://github.com/apache/arrow-rs/issues/7870#issuecomment-4543656215
> [@alamb](https://github.com/alamb) [@scovich](https://github.com/scovich) what do you think is a better idea? > > Keep `impl ValueBuilder {` `pub fn finish(mut self) -> (Vec<u8>, Vec<u8>) { `and panic vs `pub fn finish(mut self) -> Result<(Vec<u8>, Vec<u8>), ArrowError> {` I think we should mirror other APIs (where I think there is both a ressult and non result API) Mabe something like ```rust impl ValueBuilder { pub fn finish(mut self) -> (Vec<u8>, Vec<u8>) { self.try_finish.unwrap() } pub fn try_finish(mut self) -> Result<(Vec<u8>, Vec<u8>), ArrowError> { ... } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
