mneetika commented on PR #10014:
URL: https://github.com/apache/arrow-rs/pull/10014#issuecomment-4549749885

   @scovich  Thanks for catching this, and apologies for the incorrect update.
   
   You were right that `Dictionary` / `RunEndEncoded` are not valid Parquet 
Variant shredded `typed_value` layouts, so adding support in `unshred_variant` 
was wrong.
   
   I have updated the PR to target the actual issue instead: `variant_to_arrow` 
/ `variant_get(as_type=...)` output support for `DataType::Dictionary` and 
`DataType::RunEndEncoded`. The implementation now builds the logical value 
array first and delegates the final Dictionary/REE encoding to Arrow’s existing 
cast kernels.
   
   I also updated the PR title/body and added regression tests for string 
dictionary, numeric dictionary, and run-end encoded outputs.
   
   Again apologies for the incorrect PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to