Copilot commented on code in PR #10025:
URL: https://github.com/apache/arrow-rs/pull/10025#discussion_r3312184602
##########
arrow-select/src/interleave.rs:
##########
@@ -373,13 +375,89 @@ fn interleave_struct(
Ok(Arc::new(struct_array))
}
+fn interleave_list_primitive_child<O: OffsetSizeTrait, T: ArrowPrimitiveType>(
+ interleaved: &Interleave<'_, GenericListArray<O>>,
+ indices: &[(usize, usize)],
+ capacity: usize,
+ data_type: &DataType,
+) -> ArrayRef {
+ let child_arrays: Vec<&PrimitiveArray<T>> = interleaved
+ .arrays
+ .iter()
+ .map(|list| list.values().as_primitive::<T>())
+ .collect();
+
+ let has_child_nulls = child_arrays.iter().any(|a| a.null_count() > 0);
+
+ // Build values buffer by copying contiguous slices
+ let mut values: Vec<T::Native> = Vec::with_capacity(capacity);
+ for &(array, row) in indices {
+ let o = interleaved.arrays[array].value_offsets();
+ let start = o[row].as_usize();
+ let end = o[row + 1].as_usize();
+ if end > start {
+
values.extend_from_slice(&child_arrays[array].values()[start..end]);
+ }
+ }
+
+ // Build null buffer. Pre-allocate with 0x00 (all null), then:
+ // - Sources with nulls: set_bits ORs in valid bits from source.
Review Comment:
The comment says `set_bits` “ORs in” the valid bits from the source, but
`arrow_buffer::bit_mask::set_bits` overwrites the destination bit range to
exactly match the source range. Since the destination is zero-initialized and
ranges don’t overlap this happens to work, but the wording is misleading—please
update the comment to describe the actual behavior (copy/overwrite).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
