jonkeane commented on a change in pull request #10247:
URL: https://github.com/apache/arrow/pull/10247#discussion_r629517868
##########
File path: dev/archery/archery/tests/test_bot.py
##########
@@ -156,6 +156,7 @@ def handler(command, **kwargs):
@pytest.mark.parametrize(('command', 'reaction'), [
('@ursabot build', '+1'),
+ ('@ursabot build\nwith a comment', '+1'),
Review comment:
I made ARROW-12720 I started thinking about doing that splitting, but
I'm not totally sure it's a good idea to allow the command to be anywhere (or
anywhere at the beginning of a newline). The current code requires that the
comment [start with the
mention](https://github.com/apache/arrow/blob/master/dev/archery/archery/bot.py#L110)
which wasn't changed in this PR. At the very least we should discuss/decide
what the boundaries ought to be there, which we can do on that ticket before
changing that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
