etseidl commented on code in PR #9619:
URL: https://github.com/apache/arrow-rs/pull/9619#discussion_r3314532349
##########
parquet/src/column/writer/mod.rs:
##########
@@ -906,17 +910,31 @@ impl<'a, E: ColumnValueEncoder> GenericColumnWriter<'a,
E> {
page_statistics: Option<&ValueStatistics<E::T>>,
page_variable_length_bytes: Option<i64>,
) {
+ // Determine if this is a floating-point column
+ let is_float_column = matches!(self.descr.physical_type(), Type::FLOAT
| Type::DOUBLE)
Review Comment:
done in
https://github.com/apache/arrow-rs/pull/9619/commits/f98c8b3fd1fc27afbb81516153b4e8ac88cf4388
and
https://github.com/apache/arrow-rs/pull/9619/commits/4ff46cc1bb89ce6689c5b6c482834e03fae601e1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
