hhhizzz commented on PR #9956: URL: https://github.com/apache/arrow-rs/pull/9956#issuecomment-4560507353
> (I am not likely going to be able to review 8k lines in detail, however, so I will probably look at the high level first) Thanks for taking a look at this PR! I completely understand that an 8k-line diff is daunting to review in detail. To help make the review process easier, I wanted to clarify only about **3,450 lines** are production code, while the remaining 4,800+ lines are benchmarks and extensive unit/integration tests. If you still feel this is too large to review as a single PR, I would be more than happy to split this into smaller , incremental PRs.😄 Here is how we can cleanly divide the work: * **PR 1 (Infrastructure & Metrics)**: Expose `ArrowReaderMetrics` + refactor/extract `strategy.rs` and its isolated test file `selection/tests.rs` (No functional changes to the reader). * **PR 2 (Post-Decode Filter State)**: Introduce `post_filter.rs` with its internal unit tests (Laying the groundwork for the fallback path). * **PR 3 (Selection Policy & Cost Model)**: Add `cost_model.rs`, `selection_policy.rs`, integrate them into the push decoder state machine, and add the main benchmarks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
