Copilot commented on code in PR #49708:
URL: https://github.com/apache/arrow/pull/49708#discussion_r3316930647
##########
r/R/dplyr-funcs-datetime.R:
##########
@@ -724,7 +724,7 @@ register_bindings_datetime_parsers <- function() {
register_binding(
paste0("lubridate::", tolower(order)),
parser_map_factory(order),
- notes = "`locale` argument not supported"
+ notes = "`locale` argument not supported; see docs for
`parse_date_time()` mapping for supported formats"
Review Comment:
This note is applied to every generated parser, including `yq()`, but the
referenced `parse_date_time()` note does not list the `q` order token (nor does
it describe the parser-order-to-strptime mapping). Users following this new
pointer from `yq()` still won't be able to find the supported quarter format.
Please either include the missing order-token mapping in the
`parse_date_time()` notes or use parser-specific notes that only point to
documented formats.
##########
r/R/dplyr-funcs-doc.R:
##########
@@ -295,17 +295,17 @@
#' * [`week()`][lubridate::week()]
#' * [`with_tz()`][lubridate::with_tz()]
#' * [`yday()`][lubridate::yday()]
-#' * [`ydm()`][lubridate::ydm()]: `locale` argument not supported
-#' * [`ydm_h()`][lubridate::ydm_h()]: `locale` argument not supported
-#' * [`ydm_hm()`][lubridate::ydm_hm()]: `locale` argument not supported
-#' * [`ydm_hms()`][lubridate::ydm_hms()]: `locale` argument not supported
+#' * [`ydm()`][lubridate::ydm()]: `locale` argument not supported; see docs
for `parse_date_time()` mapping for supported formats
+#' * [`ydm_h()`][lubridate::ydm_h()]: `locale` argument not supported; see
docs for `parse_date_time()` mapping for supported formats
+#' * [`ydm_hm()`][lubridate::ydm_hm()]: `locale` argument not supported; see
docs for `parse_date_time()` mapping for supported formats
+#' * [`ydm_hms()`][lubridate::ydm_hms()]: `locale` argument not supported; see
docs for `parse_date_time()` mapping for supported formats
#' * [`year()`][lubridate::year()]
-#' * [`ym()`][lubridate::ym()]: `locale` argument not supported
-#' * [`ymd()`][lubridate::ymd()]: `locale` argument not supported
-#' * [`ymd_h()`][lubridate::ymd_h()]: `locale` argument not supported
-#' * [`ymd_hm()`][lubridate::ymd_hm()]: `locale` argument not supported
-#' * [`ymd_hms()`][lubridate::ymd_hms()]: `locale` argument not supported
-#' * [`yq()`][lubridate::yq()]: `locale` argument not supported
+#' * [`ym()`][lubridate::ym()]: `locale` argument not supported; see docs for
`parse_date_time()` mapping for supported formats
+#' * [`ymd()`][lubridate::ymd()]: `locale` argument not supported; see docs
for `parse_date_time()` mapping for supported formats
+#' * [`ymd_h()`][lubridate::ymd_h()]: `locale` argument not supported; see
docs for `parse_date_time()` mapping for supported formats
+#' * [`ymd_hm()`][lubridate::ymd_hm()]: `locale` argument not supported; see
docs for `parse_date_time()` mapping for supported formats
+#' * [`ymd_hms()`][lubridate::ymd_hms()]: `locale` argument not supported; see
docs for `parse_date_time()` mapping for supported formats
+#' * [`yq()`][lubridate::yq()]: `locale` argument not supported; see docs for
`parse_date_time()` mapping for supported formats
Review Comment:
This new `yq()` entry points readers to the `parse_date_time()`
supported-format notes, but those notes do not include the `q` order token used
by `yq()`. Please either document the quarter/order-token mapping in the
`parse_date_time()` section or avoid adding this generic pointer to `yq()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
