westonpace opened a new pull request #10289:
URL: https://github.com/apache/arrow/pull/10289


   Questions:
   
   - This is my first PR in the parquet namespace, I'm not sure of all the 
special rules.
   - The field ID generation doesn't happen on the `parquet::schema` -> 
`arrow::schema` phase but on the `parquet::format::schema` -> `parquet::schema` 
phase.  So in order to test I had to add `#include "generated/parquet_types.h"` 
to `arrow_schema_test.cc` and I wasn't sure if I was allowed to reference the 
`generated/*` files like that.
   - This PR simply allows user specified field id's to be persisted.  Is that 
sufficient for PARQUET-1798 (the title is rather general) or should I open up a 
dedicated JIRA?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to