BITree2004 commented on PR #50049: URL: https://github.com/apache/arrow/pull/50049#issuecomment-4565608156
Addressed the Copilot review comments in 6ad9de9: - validate the stored binary/large-binary builder type, including extension storage type - use the type singleton for default binary builders - guard typed Finish(...) overloads so extension-typed builders return TypeError instead of casting to BinaryArray/LargeBinaryArray - add regression coverage for BinaryBuilder and LargeBinaryBuilder Local verification: - cmake --build cpp/build-pr-50049 --target arrow-array-test - ./cpp/build-pr-50049/release/arrow-array-test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
