UdayanMahalwar opened a new pull request, #50061:
URL: https://github.com/apache/arrow/pull/50061

   **Rationale for this change**
   Resolves #49904
   As discussed in the issue, the legacy RandomAccessFile::ReadAt and 
RandomAccessFile::ReadAsync methods without the allow_short_read argument are 
dangerous because the caller must manually check the length of the returned 
result.
   **What changes are included in this PR?**
   Added ARROW_DEPRECATED macros to the legacy ReadAt and ReadAsync signatures 
in arrow/io/interfaces.h, scheduling them for removal in version 17.0.0.
   Updated all internal usages of these deprecated functions across the C++ 
codebase (including io, ipc, and test suites) to explicitly pass 
/*allow_short_read=*/true to preserve existing behavior.
   Wrapped the fallback definitions in interfaces.cc with 
ARROW_SUPPRESS_DEPRECATION_WARNING to prevent infinite recursion and compiler 
warnings.
   **Are these changes tested?**
   Yes, this was verified by running the existing C++ test suite. The build 
passes cleanly with -Werror and no deprecation warnings are triggered 
internally.
   **Are there any user-facing changes?**
   Yes, users compiling against Arrow C++ will now see compiler deprecation 
warnings if they use the legacy ReadAt or ReadAsync signatures.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to