HuaHuaY commented on code in PR #50008:
URL: https://github.com/apache/arrow/pull/50008#discussion_r3322927060


##########
cpp/src/parquet/properties.h:
##########
@@ -256,6 +260,10 @@ class PARQUET_EXPORT ColumnProperties {
           "Bloom filter false positive probability must be in (0.0, 1.0), got 
" +
           std::to_string(bloom_filter_options.fpp));
     }
+    if (bloom_filter_options.ndv.has_value() && 
bloom_filter_options.ndv.value() < 0) {
+      throw ParquetException("Bloom filter number of distinct values must be 
>= 0, got " +

Review Comment:
   It will create a smallest bloom filter.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to