Copilot commented on code in PR #49603:
URL: https://github.com/apache/arrow/pull/49603#discussion_r3330337874
##########
dev/release/07-flightsqlodbc-upload.sh:
##########
@@ -136,15 +136,15 @@ if [ "${PHASE_SIGN_DLL}" -gt 0 ]; then
fi
if [ "${PHASE_BUILD_MSI}" -gt 0 ]; then
- echo "[4/8 Triggering odbc_release_step in cpp_extra.yml workflow..."
- gh workflow run cpp_extra.yml \
+ echo "[4/8] Triggering odbc_release_step in package_odbc.yml workflow..."
+ gh workflow run package_odbc.yml \
--repo "${GITHUB_REPOSITORY}" \
--ref "${tag}" \
--field odbc_release_step=true
echo "[5/8 Waiting for workflow to complete. This can take a very long
time..."
REPOSITORY="${GITHUB_REPOSITORY}" \
- "${SOURCE_DIR}/utils-watch-gh-workflow.sh" "${tag}" cpp_extra.yml
+ "${SOURCE_DIR}/utils-watch-gh-workflow.sh" "${tag}" package_odbc.yml
Review Comment:
After switching the release step to `package_odbc.yml`, this watcher can
match the earlier tag-push run of the same workflow that uploaded the unsigned
DLL. `utils-watch-gh-workflow.sh` selects the latest run for the tag and
workflow without distinguishing the newly dispatched `workflow_dispatch` run,
so the script may continue before the MSI build finishes and then fail to
download the unsigned MSI. Please make the wait target the run just triggered
(for example by teaching the helper to filter by event/new run id).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
