lesam commented on PR #716: URL: https://github.com/apache/arrow-go/pull/716#issuecomment-4623185705
> Also, can we just add a single line documentation note explaining that the dictionary itself isn't compacted or modified? i.e. after execution of the filter, the dictionary itself would still contain all the same values. This is intentional, but might be non-obvious. I've added this on dictionaryTake and dictionaryFilter - did you want it on the public generic Take / Filter doc comment as well? My feeling is not to add it to the public method contract, to give more flexibility to change it in the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
