alamb commented on code in PR #10068: URL: https://github.com/apache/arrow-rs/pull/10068#discussion_r3357545705
########## parquet/benches/arrow_writer.rs: ########## @@ -18,6 +18,71 @@ #[macro_use] extern crate criterion; +// Use jemalloc, with page decay disabled, for the writer benchmarks. Review Comment: I think this might be overfitting -- using jemalloc (vs other allocators) I do't have any way to really evaluate the implications of switching allocators, and all these jemalloc tuning knobs. I fear they will have other hard to understand side effects, I am happy to have us conclude that any particular benchmark run is allocation page heavy and thus we can ignore the effects -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
