alamb opened a new pull request, #10074: URL: https://github.com/apache/arrow-rs/pull/10074
# Which issue does this PR close? Follow-on to #10020, implementing the documentation suggestion from https://github.com/apache/arrow-rs/pull/10020#discussion_r3350282205. There is no separate tracking issue. # Rationale for this change The original `with_page_store_factory` example used a `HashMap`-backed store with deliberately sparse keys to demonstrate that the writer treats `PageKey`s as opaque — useful trivia, but it made the example longer and harder to follow. A temp-file-backed store is both simpler to read and much closer to what users would actually build, since spilling pages off the heap is the whole point of the API. # What changes are included in this PR? Replaces the doctest with a `TempFilePageStore` (one temp file per column chunk: `put` appends the page, `take` seeks it back) and reflows the surrounding prose. Also tidies the `PageStore` trait docs to link out to the example. This is documentation only — no code or behavior changes. # Are these changes tested? Yes — the example is a runnable doctest that writes a record batch through the spilling store and asserts the round-tripped data matches. # Are there any user-facing changes? Documentation only; no public API or behavior changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
