alamb commented on a change in pull request #281:
URL: https://github.com/apache/arrow-datafusion/pull/281#discussion_r630081042



##########
File path: .github/workflows/rust.yml
##########
@@ -133,6 +132,52 @@ jobs:
           # snmalloc requires cmake so build without default features
           cargo test --no-default-features
 
+  integration-test:
+    name: "Integration Test"
+    needs: [linux-build-lib]
+    runs-on: ubuntu-latest
+    services:

Review comment:
       this is cool to use a github actions service. 👍 

##########
File path: integration-tests/compare_sql_output.py
##########
@@ -0,0 +1,77 @@
+# Licensed to the Apache Software Foundation (ASF) under one

Review comment:
       This is really cool -- thank you @Jimexist  . It reminds me of 
`pg_regres` 👍 
   
   This script is simple enough that we can always rewrite it in Rust if we 
would prefer to reduce the number of languages used, but python is a good 
choice for scripting I think as we already have the python bindings as well as 
some dev scripts in python. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to