Copilot commented on code in PR #50104:
URL: https://github.com/apache/arrow/pull/50104#discussion_r3362053412
##########
ci/scripts/cpp_test.sh:
##########
@@ -50,7 +50,7 @@ fi
if ! type storage-testbench >/dev/null 2>&1; then
exclude_tests+=("arrow-gcsfs-test")
fi
-if ! type minio >/dev/null 2>&1; then
+if ! type weed >/dev/null 2>&1; then
exclude_tests+=("arrow-s3fs-test")
fi
Review Comment:
`arrow-s3fs-test` is currently gated on the presence of the `weed`
executable, but the C++ S3 test harness still launches the `minio` binary (see
`cpp/src/arrow/filesystem/s3_test_util.cc` uses `kMinioExecutableName =
"minio"`). In environments where SeaweedFS is installed but MinIO is not (as in
the updated dockerfiles/CI), this will cause S3 tests to run and then fail at
runtime because `minio` cannot be executed. Gate on `minio` until the C++ tests
are migrated to SeaweedFS (or updated to use `ARROW_TEST_S3_*` to target an
external S3 service).
##########
ci/scripts/r_install_system_dependencies.sh:
##########
@@ -53,8 +53,8 @@ esac
if [ "$ARROW_S3" == "ON" ] || [ "$ARROW_GCS" == "ON" ] || [ "$ARROW_R_DEV" ==
"TRUE" ]; then
# The Dockerfile should have put this file here
- if [ "$ARROW_S3" == "ON" ] && [ -f
"${ARROW_SOURCE_HOME}/ci/scripts/install_minio.sh" ] && [ "`which wget`" ]; then
- "${ARROW_SOURCE_HOME}/ci/scripts/install_minio.sh" latest /usr/local
+ if [ "$ARROW_S3" == "ON" ] && [ -f
"${ARROW_SOURCE_HOME}/ci/scripts/install_seaweedfs.sh" ] && [ "`which wget`" ];
then
+ "${ARROW_SOURCE_HOME}/ci/scripts/install_seaweedfs.sh" 4.31 /usr/local
fi
Review Comment:
The SeaweedFS install is currently conditioned on `which wget`, but
`install_seaweedfs.sh` already supports either `wget` or `curl` (and this
script installs curl dependencies earlier). As written, SeaweedFS installation
can be skipped unnecessarily on images that have `curl` but not `wget`, leading
to later S3-related tests being skipped/failing due to missing `weed`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
