pitrou commented on code in PR #49940:
URL: https://github.com/apache/arrow/pull/49940#discussion_r3381015294
##########
cpp/src/arrow/CMakeLists.txt:
##########
@@ -855,15 +851,13 @@ if(ARROW_COMPUTE)
list(APPEND ARROW_COMPUTE_SHARED_INSTALL_INTERFACE_LIBS Arrow::arrow_shared)
list(APPEND ARROW_COMPUTE_STATIC_LINK_LIBS arrow_static)
list(APPEND ARROW_COMPUTE_SHARED_LINK_LIBS arrow_shared)
+ list(APPEND ARROW_COMPUTE_STATIC_LINK_LIBS ${ARROW_XSIMD})
+ list(APPEND ARROW_COMPUTE_SHARED_PRIVATE_LINK_LIBS ${ARROW_XSIMD})
Review Comment:
I don't see xsimd in use anywhere in `arrow/compute`, do you remember why
this was required @raulcd ?
Edit: perhaps because of `src/arrow/util/utf8_internal.h`? It's a pity this
indirect dependency isn't picked up automatically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
