alamb commented on code in PR #10111:
URL: https://github.com/apache/arrow-rs/pull/10111#discussion_r3391668737
##########
arrow-ipc/src/writer.rs:
##########
@@ -1984,7 +1987,7 @@ fn write_array_data(
offset = encode_sink_buffer(
null_buffer,
- buffers,
+ &mut meta.buffers,
Review Comment:
I think it is a fine follow on -- the downside as you say is that it is now
less obvious what is being used. The upside is that the logic is more
encapsulated (the caller doesn't have to know that only the `buffers` are being
used 🤔 )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
