Braedon-Wooding-Displayr commented on PR #742: URL: https://github.com/apache/arrow-rs-object-store/pull/742#issuecomment-4701182318
@kevinjqliu I've applied all of your comments above. Secondarily, I've had a deep scan and we don't seem to log headers anywhere but what I've done is added a new function to client/builder.rs called sensitive_header that does what you are saying and we call that when adding the encryption-key/SHA256. I felt it's better to be safe now rather than expose accidentally later if someone adds header logging. GCP had a special function to add bearer_auth which I simplified to use this sensitive header function too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
