alamb opened a new issue, #753:
URL: https://github.com/apache/arrow-rs-object-store/issues/753

   **Is your feature request related to a problem or challenge? Please describe 
what you are trying to do.**
   One thing I noticed while reviewing 
https://github.com/apache/arrow-rs-object-store/pull/643 is that basically all 
error paths are untested in `LocalFileSystem` as they require IO errors to 
trigger.
   
   For example, using `llvm-cov` you can do
   ```shell
   cargo llvm-cov --html test -p object_store
   ```
   
   And then look at local.html:  
[local.rs.html](https://github.com/user-attachments/files/28969041/local.rs.html)
   
   And you'll see the errors are totally uncoveed
   <img width="1226" height="1202" alt="Image" 
src="https://github.com/user-attachments/assets/5e8fb60d-04f6-48e4-b3fe-732cfdc7a1a7";
 />
   
   **Describe the solution you'd like**
    I would like to also test the error paths. 
   
   **Describe alternatives you've considered**
   
   for many of them, this will likely require mocking the various 
`std::fs::File` apis somehow to inject determinisitic errors.
   
   If anyone wants to work on this issue, I suggest creating a PR with the 
scaffolding and one or two new tests so we can agree on the pattern. Then we 
can make follow on PRs to fill out the rest. 
   
   **Additional context**
   <!--
   Add any other context or screenshots about the feature request here.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to