kiszk commented on code in PR #48215:
URL: https://github.com/apache/arrow/pull/48215#discussion_r3425963054
##########
cpp/src/parquet/arrow/reader_internal.cc:
##########
@@ -851,7 +851,41 @@ Status TransferHalfFloat(RecordReader* reader, MemoryPool*
pool,
std::shared_ptr<ChunkedArray> chunked_array;
RETURN_NOT_OK(
TransferBinary(reader, pool, field->WithType(binary_type),
&chunked_array));
+#if ARROW_LITTLE_ENDIAN
ARROW_ASSIGN_OR_RAISE(*out, chunked_array->View(field->type()));
+#else
+ // Convert little-endian bytes from Parquet to native-endian HalfFloat
Review Comment:
I also prefer to use @pitrou 's approach to make it simple to easily
maintain.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
